Re: [PATCH] btrfs-progs: Make the process of create root tree to a function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 25, 2017 at 03:23:36PM +0800, Gu Jinxiang wrote:
> make_btrfs is too long to understand, make creatation of root tree
> in a function.

Good cleanup, but the changelog could be improved. There are some
changes not obvious from the changes, like that you now iterate some of
the roots and use the reference_root_table for translation. This makes
it a bit harder to review the patch as the code is not just moved to a
function but also improved on the way. Sometimes it's better to do it in
two steps, but not absolutely necessary in this case.

Nevertheless, patch applied, with the updated changelog.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux