On Fri, Aug 18, 2017 at 09:04:19AM +0200, Goffredo Baroncelli wrote: > Hi All, > > Piotr and Chris, pointed me at these bugs which could be triggered by this test case: > > # btrfs sub create test1 > # btrfs sub create test1/test2 > # btrfs sub snap test1 test1.snap > # btrfs fi du -s test1 > Total Exclusive Set shared Filename > 0.00B 0.00B 0.00B test1 > # btrfs fi du -s test1.snap > Total Exclusive Set shared Filename > ERROR: cannot check space of 'test1.snap': Inappropriate ioctl for device > > These are two bugs: > 1) in the function du_walk_dir() the error returned by du_add_file() normally > is ignored. But if du_walk_dir() "walks" the last items, the error is returned > to the caller > 2) in the function du_add_file() it doesn't make sense to call > lookup_path_rootid() when the inode is BTRFS_EMPTY_SUBVOL_DIR_OBJECTID: in this > case the function doesn't return a valid value. Thanks, patches applied and I've added a testcase following the instructions above. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
