On Wed, Aug 02, 2017 at 02:02:11PM +0800, Anand Jain wrote: > > Hi Darrick, > > Thanks for commenting.. > > >>+ memcpy(&sb->s_uuid, fs_info->fsid, BTRFS_FSID_SIZE); > > > >uuid_copy()? > > It requires a larger migration to use uuid_t, IMO it can be done all > together, in a separate patch ? > > Just for experiment, starting with struct btrfs_fs_info.fsid and > to check its foot prints, I just renamed fsid to fs_id, and compiled. > It reports 73 'has no member named ‘fsid'' errors. > So looks like redefining u8 fsid[] to uuid_t fsid and further updating > all its foot prints, has to be simplified. Any suggestions ? Cocinelle script? <shrug> It was a fairly simply transition for xfs and others, though from a simple grep it looks like btrfs uses open coded u8 arrays in a few more places. --D > > Thanks, Anand > > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
