On Mon, Jul 24, 2017 at 03:14:26PM -0400, josef@xxxxxxxxxxxxxx wrote: > From: Josef Bacik <jbacik@xxxxxx> > > Our dir_context->pos is supposed to hold the next position we're > supposed to look. If we successfully insert a delayed dir index we > could end up with a duplicate entry because we don't increase ctx->pos > after doing the dir_emit. > Looks good. Reviewed-by: Liu Bo <bo.li.liu@xxxxxxxxxx> Thanks, -liubo > Signed-off-by: Josef Bacik <jbacik@xxxxxx> > --- > fs/btrfs/delayed-inode.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c > index 8ae409b..19e4ad2 100644 > --- a/fs/btrfs/delayed-inode.c > +++ b/fs/btrfs/delayed-inode.c > @@ -1727,6 +1727,7 @@ int btrfs_readdir_delayed_dir_index(struct dir_context *ctx, > > if (over) > return 1; > + ctx->pos++; > } > return 0; > } > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
