On 7/13/17 9:58 AM, Holger Hoffstätte wrote: > On 07/13/17 15:25, Jeffrey Mahoney wrote: >> On 7/13/17 12:16 AM, Anand Jain wrote: >>> As users generally organize the subvols and snapshots based on the subvol >>> directory hierarchy. So providing an ability to sort them by topid would >>> help. Thanks. >> >> What is a topid? I needed to look at the code to discover this and it's >> not even documented as part of the root_info structure. Users are going >> to have no idea what this means. > > The idea seems similar to my attempt to add listing of toplevel-only > (i.e. non-snapshot) subvolumes, which can be found here: > > https://github.com/hhoffstaette/btrfs-progs/commit/f0a065e02b > > I ended up not submitting it since nobody seemed interested at the time > and I could work around it for my own purposes by filtering manually on > parent uuid (more precisely the lack thereof). I'm not debating the utility of the idea -- just that it is a completely opaque name for someone not already familiar with the internals. One of the biggest complaints I hear consistently about using btrfs is that the UI is difficult to use. It's on my team's TODO list to fix some of this, but part of that is trying to make sure that new additions are easy to use. This patch uses an abbreviation that's used nowhere outside of the code and offers no documentation for it. That's what my issue is. -Jeff -- Jeff Mahoney SUSE Labs
Attachment:
signature.asc
Description: OpenPGP digital signature
