On Mon, Jun 19, 2017 at 1:26 PM, Henk Slager <eye1tm@xxxxxxxxx> wrote:
> On 16-06-17 03:43, Qu Wenruo wrote:
>> Since incompat feature NO_HOLES still allow us to have explicit hole
>> file extent, current check is too restrict and will cause false alert
>> like:
>>
>> root 5 EXTENT_DATA[257, 0] shouldn't be hole
>>
>> Fix it by removing the restrict hole file extent check.
>>
>> Reported-by: Henk Slager <eye1tm@xxxxxxxxx>
>> Signed-off-by: Qu Wenruo <quwenruo@xxxxxxxxxxxxxx>
>> ---
>> cmds-check.c | 6 +-----
>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/cmds-check.c b/cmds-check.c
>> index c052f66e..7bd57677 100644
>> --- a/cmds-check.c
>> +++ b/cmds-check.c
>> @@ -4841,11 +4841,7 @@ static int check_file_extent(struct btrfs_root *root, struct btrfs_key *fkey,
>> }
>>
>> /* Check EXTENT_DATA hole */
>> - if (no_holes && is_hole) {
>> - err |= FILE_EXTENT_ERROR;
>> - error("root %llu EXTENT_DATA[%llu %llu] shouldn't be hole",
>> - root->objectid, fkey->objectid, fkey->offset);
>> - } else if (!no_holes && *end != fkey->offset) {
>> + if (!no_holes && *end != fkey->offset) {
>> err |= FILE_EXTENT_ERROR;
>> error("root %llu EXTENT_DATA[%llu %llu] interrupt",
>> root->objectid, fkey->objectid, fkey->offset);
>
>
> Thanks for the patch, I applied it on v4.11 btrfs-progs and re-ran the check:
> # btrfs check -p --readonly /dev/mapper/smr
While looking at new kernel+progs releases and my script logs, I see
I made copy-paste error; of course it is the lowmem mode:
# btrfs check -p --mode lowmem --readonly /dev/mapper/smr
> on filesystem mentioned in:
> https://www.spinics.net/lists/linux-btrfs/msg66374.html
>
> and now the "shouldn't be hole" errors don't show up anymore.
>
> Tested-by: Henk Slager <eye1tm@xxxxxxxxx>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
