At 06/27/2017 07:55 AM, Liu Bo wrote:
So btrfs_set_header_flags() vs btrfs_set_header_flag, the difference is sort of similar to "=" vs "|=", when creating and initialising a new extent buffer, convert uses the former one which clears header_rev by accident.
Thanks for catching this one. Reviewed-by: Qu Wenruo <quwenruo@xxxxxxxxxxxxxx> Thanks, Qu
Signed-off-by: Liu Bo <bo.li.liu@xxxxxxxxxx> --- convert/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/convert/common.c b/convert/common.c index 40bf32c..f0dd2cf 100644 --- a/convert/common.c +++ b/convert/common.c @@ -167,7 +167,7 @@ static int setup_temp_extent_buffer(struct extent_buffer *buf, btrfs_set_header_generation(buf, 1); btrfs_set_header_backref_rev(buf, BTRFS_MIXED_BACKREF_REV); btrfs_set_header_owner(buf, owner); - btrfs_set_header_flags(buf, BTRFS_HEADER_FLAG_WRITTEN); + btrfs_set_header_flag(buf, BTRFS_HEADER_FLAG_WRITTEN); write_extent_buffer(buf, chunk_uuid, btrfs_header_chunk_tree_uuid(buf), BTRFS_UUID_SIZE); write_extent_buffer(buf, fsid, btrfs_header_fsid(), BTRFS_FSID_SIZE);
-- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
