Re: [PATCH] Btrfs: inode.c convert local flags int -> bool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 15.06.2017 13:48, Timofey Titovets wrote:
> Just conversion from int to bool where it applicable
> Only change function local flags to not break external
> function / structures
> 
> Reasons:
> 1. Separate variables like:
>    - ret = 1 - ret value with special handling from caller
>    - insert = 1 - three-state flag
>    - reserve = 1 - just a flag
>    - reserved = 0 - just a flag
>    - scanned = 0 - counter
> 2. Sync usage of bool for flags with other code
> for decrease blending int/bool
> 
> Signed-off-by: Timofey Titovets <nefelim4ag@xxxxxxxxx>
While I myself am a fan of bool and hate it when people use an int to
signify a boolean variable patches such as this one create needless
churn. If you have a fix, or a major refactoring to contribute and you
can also manage to squeeze in such a fixup then yes, but this - no.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux