Re: [PATCH 2/5] btrfs-progs: Enhance chunk item validation check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





At 05/30/2017 01:39 AM, David Sterba wrote:
On Mon, May 15, 2017 at 04:27:39PM +0800, Qu Wenruo wrote:
btrfs_check_chunk_valid() doesn't check if
1) chunk flag has conflicting flags
    For example chunk type DATA|METADATA|RAID1|RAID10 is completely
    invalid, while current check_chunk_valid() can't detect it.
2) num_stripes is invalid for RAID10
    Num_stripes 5 is not valid for RAID10.

This patch will enhance btrfs_check_chunk_valid() to handle above cases.

Signed-off-by: Qu Wenruo <quwenruo@xxxxxxxxxxxxxx>

Most tests fail with this patch, mkfs or from restored images created.
Simple test-check or test-misc fails in the first test. Have I missed
some other patch or test update?


Sorry, I formatted patch based on an old branch, which doesn't have the extra fix for single profile.

I'll update the branch and add the needed test case in next branch, along with infrastructure update to make loop device setup more easy to use.

Thanks,
Qu


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux