On Fri, May 19, 2017 at 01:01:42PM -0700, Liu Bo wrote: > On Fri, May 19, 2017 at 09:06:42PM +0200, David Sterba wrote: > > On Tue, May 09, 2017 at 05:02:15PM -0600, Liu Bo wrote: > > > Before this, we use 'filled' mode here, ie. if all range has been filled > > > with EXTENT_DEFRAG bits, get to clear it, but if the defrag range joins > > > the adjacent delalloc range, then we'll leave EXTENT_DEFRAG bits until > > > evicting inode. > > > > > > This clears the bit if any was found within the ordered extent. > > > > What effects, good or bad, can this have? > > > > Is it worth backporting to stable trees? > > The good effect of this patch is to free extent_state quickly if we > don't need it, without this, it can't be freed since the extent_state > has at least EXTENT_DEFRAG bit in ->state. > > Just notice that I made a mistake in the changelog, the bit will be > cleared until releasing pages, which may be called by > invalidate_mapping_ranges(), not evicting inode. > > No, I don't think it's a candidate for stable tree. Thanks for the answers. Please update the patch changelog and resend. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
