On Wed, Apr 19, 2017 at 05:43:19AM -0700, Sahil Kang wrote: > This is my first patch so it's a minor code change. > I think removing the early continue from the loop makes the function a > little easier to follow. I think the opposite. In the current code, it's clear that if ret is 0, then there's a shortcut. While your code change is functionally equivalent, it takes a bit more time to see that the for loop does nothing if ret == 0 and overall it looks like we don't handle the return value coming from find_get_pages_contig, in exchange for some ?: trickery that requires a comment. So I don't think this patch makes code better and I'm not going to apply it, sorry. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
