On Fri, Mar 17, 2017 at 08:35:01AM +0800, Qu Wenruo wrote: > > > At 03/17/2017 12:33 AM, David Sterba wrote: > > On Thu, Mar 16, 2017 at 11:18:31AM +0800, Qu Wenruo wrote: > >> Since btrfs_reserved_ranges array is just used to store btrfs reserved > >> ranges, no one will nor should modify them at run time, make them static > >> and const will be better. > >> > >> This also eliminates the use of immediate number 3. > > > > Adding const is fine, but you shouldn't define the structure inside > > header, even as static. > > Any reason why we shouldn't define const static array in header? > > Is extra .text segments usage the problem? No, the problem is definition in a header. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
