Re: [PATCH/fstest] btrfs/139: correctly receive clones to mounted subvol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 23, 2017 at 12:07:35AM +0100, Benedikt Morbach wrote:
> clone needs to resolve the paths of the involved subvolumes in the target
> fs from their UUIDs. When doing so it might need to strip the prefix
> that is mounted as the root of the fs from those paths.
> 
> It didn't do so correctly when processing the source of "clone" commands
> 
> This is a regression test for
>     btrfs-progs: receive: handle root subvol path in clone
> ---
> 
> fstest for the patch mentioned above (see also https://mail-archive.com/linux-btrfs@xxxxxxxxxxxxxxx/msg61848.html)
> 
> I thought I'd send this to linux-btrfs first as I'm not sure what the policy is
> wrt submitting fstests aren't fixed upstream yet.

Sending tests in advance is a common practice, failing test can be
expected on older kernels or installed btrfs-progs. In this case it's
not a kernel bug/feature test so I'm not entirely sure if fstests is the right
testsuite. I have adated this test and added it to the btrfs-progs.

> It's my first fstest and even though the other tests were helpful and it seems
> to work, I still assume I've made a couple of mistakes here and there.

IIRC fstests do not use the execution wrappers like run_check and there
could be more. If you want to continue, please resend to
fstests@xxxxxxxxxxxxxxx, but as far as I'm concerned the test in
btrfs-progs is almost done (the fssum utility needs to be added).
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux