Re: [PATCH v2] btrfs: Change qgroup_meta_rsv to 64bit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 14, 2017 at 08:31:26AM -0500, Goldwyn Rodrigues wrote:
> 
> 
> On 03/14/2017 07:30 AM, David Sterba wrote:
> > On Tue, Mar 14, 2017 at 05:25:09AM -0500, Goldwyn Rodrigues wrote:
> >> From: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx>
> >>
> >> Using an int value is causing qg->reserved to become negative and
> >> exclusive -EDQUOT to be reached prematurely.
> > 
> > V1 had a reproducer, I think it's fine to keep it here so I'll copy it.
> > 
> > Reviewed-by: David Sterba <dsterba@xxxxxxxx>
> > 
> 
> I am adding a testcase in (x)fstests which covers both qgroup issues for
> which I have sent the patches. I am fine either ways.

The fstests testcase is orthogonal to the changelog describing the steps
to reproduce the bug (it could just roughly describe the idea), as it
helps to understand what's the patch going to fix.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux