On Tue, Mar 07, 2017 at 06:35:02PM +0000, Filipe Manana wrote: > On Tue, Mar 7, 2017 at 4:05 PM, David Sterba <dsterba@xxxxxxx> wrote: > > On Mon, Mar 06, 2017 at 11:32:47PM +0000, fdmanana@xxxxxxxxxx wrote: > >> From: Filipe Manana <fdmanana@xxxxxxxx> > >> > >> The delalloc_end parameter for extent_clear_unlock_delalloc() is never > >> used, and only making the code for all callers longer and more complex. > >> Just remove it. > > > > It's been added on purpose > > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=dda3245eca18c73413a854a834c41fc770feb0dd > > > > "btrfs: expand cow_file_range() to support in-band dedup and > > subpage-blocksize" > > > > so we can merge both mentioned patchsets for testing. > > I definitely missed that. To be honest I was finding it strange that > none of the usual cleanup fanatics noticed it before. I was disappointed for a minute that I couldn't remove it, you bet. > Anyway I'm sending a v2 of the 2nd patch so that it works correctly on > top of Qu's patchset that I reviewed recently. I've added Qu's patches > to my 4.11 integration branch just so that I could work on top of > them, feel free to pick stuff from there if convenient or ignore > otherwise. Let's keep it in your branch then. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
