Re: [PULL] Fix ioctls on 32bit/64bit userspace/kernel, for 4.10

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 08, 2017 at 05:51:28PM +0100, David Sterba wrote:
> could you please merge this single-patch pull request, for 4.10 still?  There
> are quite a few patches on top of v4.10-rc7 so this IMHO does not look like
> look too bad even late in the release cycle. Though it's a fix for an uncommon
> usecase of 32bit userspace on 64bit kernel, it fixes basically operation of the
> ioctls. Thanks.

It's not uncommon.  Pretty much every 32-on-64 combination was broken, and
some archs (like mips, both endians) use 32-on-64 on all non-museal hardware.

I've tested that your patch fixes at least:
* x32 on amd64
* armhf on arm64

So big thanks for this fix!


There are other broken ioctls, for example:
/mnt/vol1/b: fiemap error 25: Inappropriate ioctl for device
/mnt/vol1/a: fiemap error 25: Inappropriate ioctl for device
but the last I checked, fiemap doesn't live in fs/btrfs/

Meow!
-- 
Autotools hint: to do a zx-spectrum build on a pdp11 host, type:
  ./configure --host=zx-spectrum --build=pdp11
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux