On Thu, Feb 02, 2017 at 11:11:15AM -0800, Liu Bo wrote: > On Thu, Feb 02, 2017 at 07:42:43PM +0100, David Sterba wrote: > > On Mon, Jan 30, 2017 at 12:26:30PM -0800, Liu Bo wrote: > > > This creates a helper to manipulate page bits to avoid duplicate uses. > > > > This seems too short for what the patch does. It adds a new page ops bit > > that would deserve a separate patch. Please try to split it to smaller > > parts. > > Hmm..the newly added 'PAGE_LOCK' is only used in lock_delalloc_pages in > order to make the helper lock pages. > > I could firstly introduce the helper from extent_clear_unlock_delalloc() > , then introduce the new 'PAGE_LOCK' and make lock_delalloc_pages and > __unlock_for_delalloc to use the helper, does it sound better to review > and bisect? This sounds better, thanks. The reason is mostly from the review side. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
