Re: [PATCH] btrfs-progs: fsck-tests: missing csum test script

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 17, 2017 at 04:06:27PM +0100, David Sterba wrote:
> It's not clear from the test what's the purpose. There's one corrupted
> csum but the whole csum tree rebuild option is used. This is a pretty
> basic check that the --init-csum-tree works, so it should be mentioned
> somewhere in the test script.

I'll rename directory to 027-verify-init-csum-tree instead of current one.

Is it possible, to fix only the corrupted csum instead of re-building the 
csum-tree?

> 
> Please don't use btrfs-debug-tree, it's been obsoleted by the dump-tree
> subcommand. And you can use the '-t csum' option to dump just the csum
> tree.

> 
> This can be simplified to one sed command.
> 

> 
> Here we want to capture the output from 'check' for analysis in case of
> problems.
> 
Will fix above three issues with next patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux