On Tue, Nov 22, 2016 at 10:42:40AM +0100, Christoph Hellwig wrote:
> On Fri, Nov 18, 2016 at 12:04:38PM -0800, Omar Sandoval wrote:
> > > +static u64 bio_end_offset(struct bio *bio)
> > > +{
> > > + struct bio_vec *last = &bio->bi_io_vec[bio->bi_vcnt - 1];
> > > +
> > > + return page_offset(last->bv_page) + last->bv_len - last->bv_offset;
> >
> > Why is this minus bv_offset and not plus? Am I misunderstanding
> > bv_offset?
>
> This should be a plus, thanks.
>
> Can anyone help me on how to get test coverage for the compression
> code?
I'm not surprised xfstests missed this one since it's just readahead.
You might be able to get better coverage with
export MOUNT_OPTS="-o compress-force"
--
Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
