Re: [PATCH 1/2] btrfs: remove old tree_root dirent processing in btrfs_real_readdir()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 14, 2016 at 09:08:14PM -0500, Jeff Mahoney wrote:
> >> -			 */
> >> -			if (location.type == BTRFS_ROOT_ITEM_KEY &&
> >> -			    location.objectid == root->root_key.objectid) {
> >> -				over = 0;
> >> -				goto skip;
> >> -			}
> >> -			over = !dir_emit(ctx, name_ptr, name_len,
> >> -				       location.objectid, d_type);
> >> +		over = !dir_emit(ctx, name_ptr, name_len, location.objectid,
> >> +				 d_type);
> >>  
> >> -skip:
> >> -			if (name_ptr != tmp_name)
> >> -				kfree(name_ptr);
> >> +		if (name_ptr != tmp_name)
> >> +			kfree(name_ptr);
> >>  
> >> -			if (over)
> >> -				goto nopos;
> >> -			emitted = true;
> > 
> > Shouldn't this line (getting rid of emitted) be in the next patch?
> 
> Yep.  Good catch.

Updated.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux