Re: [PATCH] btrfs-progs: send-test: add checking of clone-src option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 08, 2016 at 08:53:04AM +0900, Tsutomu Itoh wrote:
> On 2016/11/08 0:16, David Sterba wrote:
> > On Fri, Nov 04, 2016 at 05:35:18PM +0900, Tsutomu Itoh wrote:
> >> +before_size=`ls -l "$here"/send.stream.before | awk '{print $5}'`
> >> +after_size=`ls -l "$here"/send.stream.after | awk '{print $5}'`
> > 
> > Thanks for the test. Minor fixes: "stat --format=%s" instead of the
> > above, and /dev/zero instead of urandom and stream redirection so it
> > works in my NFS setup.
> 
> Thanks for the fixing.
> But following command should be old btrfs. So please use 'btrfs' instead
> of '$TOP/btrfs'.
> 
>    run_check $SUDO_HELPER $TOP/btrfs send -f "$here"/send.stream.before \
>            -c subv-snap1_1 -c subv-snap2_1 subv-snap1_[23] subv-snap2_[23]

Oh, I see, but this would make the test unreliable. What if there's a
updated version installed? So we have to produce the right stream and
then compare the result with the one generated by the built version.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux