On Wed, Oct 19, 2016 at 11:35:03AM +0900, Tsutomu Itoh wrote: > We cannot send multiple snapshots at once by -p option. We cannot like that it's broken, or we cannot because it's not supposed to work that way. I guess it's the former, but the changelog text is a bit confusing. > > [before] > # btrfs send -f /tmp/data0 -p Snap0 Snap[12] > At subvol Snap1 > At subvol Snap2 > ERROR: parent determination failed for 0 > # > > [after] > # btrfs send -f /tmp/data0 -p Snap0 Snap[12] > At subvol Snap1 > At subvol Snap2 > # I'm not sure it's fixed, I wrote a simple test, attached, that triggers the bug even with the patch applied.
#!/bin/bash # # minimal test for the following syntax: btrfs send -p parent subvol1 subvol2 source $TOP/tests/common check_prereq mkfs.btrfs check_prereq btrfs setup_root_helper prepare_test_dev 2g run_check $TOP/mkfs.btrfs -f $IMAGE run_check_mount_test_dev here=`pwd` cd "$TEST_MNT" || _fail "cannot chdir to TEST_MNT" run_check $SUDO_HELPER btrfs subvolume create subv-parent run_check $SUDO_HELPER dd if=/dev/urandom of=subv-parent/file bs=1M count=10 run_check $SUDO_HELPER btrfs subvolume snapshot -r subv-parent subv-snap1 run_check $SUDO_HELPER dd if=/dev/urandom of=subv-parent/file bs=1M count=10 run_check $SUDO_HELPER btrfs subvolume snapshot -r subv-parent subv-snap2 run_check $SUDO_HELPER dd if=/dev/urandom of=subv-parent/file bs=1M count=10 run_check $SUDO_HELPER btrfs subvolume snapshot -r subv-parent subv-snap3 run_check truncate -s0 "$here"/send.stream run_check chmod a+w "$here"/send.stream run_check $SUDO_HELPER btrfs send -f "$here"/send.stream -p subv-snap1 subv-snap2 subv-snap3 cd "$here" || _fail "cannot chdir back to test directory" run_check_umount_test_dev
