On Tue, 18 Oct 2016 09:39:32 +0800
Qu Wenruo <quwenruo@xxxxxxxxxxxxxx> wrote:
> > static const char * const cmd_inspect_inode_resolve_usage[] = {
> > "btrfs inspect-internal inode-resolve [-v] <inode> <path>",
> > "Get file system paths for the given inode",
> > @@ -702,6 +814,8 @@ const struct cmd_group inspect_cmd_group = {
> > 0 },
> > { "min-dev-size", cmd_inspect_min_dev_size,
> > cmd_inspect_min_dev_size_usage, NULL, 0 },
> > + { "bg_analysis", cmd_inspect_bg_analysis,
> > + cmd_inspect_bg_analysis_usage, NULL, 0 },
>
> Just naming preference, IMHO show-block-groups or dump-block-groups
> seems better for me.
And in any case please don't mix separation by "-" and "_" in the same command
string. In btrfs tool the convention is to separate words in subcommand names
using "-".
--
With respect,
Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
