Re: [PATCH] btrfs-progs: Fix warning_trace compile error if backtrace is disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 06, 2016 at 04:47:19PM +0800, Qu Wenruo wrote:
> If we disable backtrace, btrfs-progs can't be compiled since we don't
> have warning_trace defined.
> 
> Fix by move it out of #ifndef BTRFS_DISABLE_BACKTRACE block.

But now this breaks with backtrace, eg:

kerncompat.h: In function ‘warning_trace’:
kerncompat.h:91:3: warning: implicit declaration of function ‘print_trace’ [-Wimplicit-function-declaration]
   print_trace();
   ^~~~~~~~~~~
kerncompat.h: At top level:
kerncompat.h:97:20: warning: conflicting types for ‘print_trace’
 static inline void print_trace(void)
                    ^~~~~~~~~~~
kerncompat.h:97:20: error: static declaration of ‘print_trace’ follows non-static declaration
kerncompat.h:91:3: note: previous implicit declaration of ‘print_trace’ was here
   print_trace();

I've fixed it and will add a script to cycle through common build
configuration so we can automate that a bit.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux