Re: [PATCH 2/2] btrfs-progs: super-recover: Reuse btrfs_read_dev_super function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





At 09/23/2016 09:26 PM, David Sterba wrote:
On Tue, Sep 20, 2016 at 10:19:02AM +0800, Qu Wenruo wrote:
We have enhanced super block validation check in disk_io.c, while
super-recover doesn't use that function and use a custom one.

That is duplicated, so reuse btrfs_read_dev_super to handle it, which
not only enhanced super check, but also reduce the code length.

Yeah, the existing check_super does way more checks compared to this
one. Applied, thanks.


Sorry David, this patch can't be applied without previous patch.

As this patch relies on previous patch to get meaningful return value, to check if it's a real error or that superblock just doesn't exist.

I'll update previous patch soon.

Thanks,
Qu


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux