Re: [PATCH] btrfs: btrfs_debug should consume fs_info when DEBUG is not defined

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 21, 2016 at 12:17:37PM -0400, Jeff Mahoney wrote:
> We can hit unused variable warnings when btrfs_debug and friends are
> just aliases for no_printk.  This is due to the fs_info not getting
> consumed by the function call, which can happen if convenenience
> variables are used.  This patch adds a new btrfs_no_printk static inline
> that consumes the convenience variable and does nothing else.  It
> silences the unused variable warning and has no impact on the generated
> code:
> 
> $ size fs/btrfs/extent_io.o*
>    text	   data	    bss	    dec	    hex	filename
>   44072	    152	     32	  44256	   ace0	fs/btrfs/extent_io.o.btrfs_no_printk
>   44072	    152	     32	  44256	   ace0	fs/btrfs/extent_io.o.no_printk
> 
> Fixes: 27a0dd61a5 (Btrfs: make btrfs_debug match pr_debug handling related to DEBUG)
> Signed-off-by: Jeff Mahoney <jeffm@xxxxxxxx>

Looks good, aded to the queue.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux