Re: [PATCH] btrfs-progs: add option to run balance as daemon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2016-07-26 13:07, David Sterba wrote:
On Mon, Jul 11, 2016 at 10:44:30AM +0900, Satoru Takeuchi wrote:
+					chdir("/");

You should check the return value of chdir(). Otherwise
we get the following warning message at the build time.

Can we actually fail to change directory to '/' ? Otherwise I think the
warning should be silenced so the build is clean.
It is theoretically possible, but in practice it means you either have failing hardware or your kernel is broken somehow, both of which should be causing all kinds of other issues, and thus we don't really gain anything from trying to catch the error.

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux