Re: [PATCH] Btrfs: fix memory leak of reloc_root

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 19, 2016 at 03:36:05PM -0700, Liu Bo wrote:
> When some critical errors occur and FS would be flipped into RO,
> if we have an on-going balance, we can end up with a memory leak
> of root->reloc_root since btrfs_drop_snapshots() bails out
> without freeing reloc_root at the very early start.
> 
> However, we're not able to free reloc_root in btrfs_drop_snapshots()
> because its caller, merge_reloc_roots(), still needs to access it to
> cleanup reloc_root's rbtree.
> 
> This makes us free reloc_root when we're going to free fs/file roots.
> 
> Signed-off-by: Liu Bo <bo.li.liu@xxxxxxxxxx>

Reviewed-by: David Sterba <dsterba@xxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux