On Wed, Jul 13, 2016 at 10:05:36AM +0300, Nikolay Borisov wrote: > Currently most of the messages btrfs produce are not rate limited. > Recently I came accross a case where due to FS corruption an excessive > amount of printk caused the softlockup detector to trigger and reset > the server. This patch does the following changes: > > * The message which was printed is converted to use the ratelimited > version of btrfs_info function. This will prevent it from exploding > in the future. > > * In addition to the above change, also add a sort of a "safet net" to > all non-ratelimited prints by introducing separate ratelimiting for > every message class when the "naked" btrfs_info is called. > > Signed-off-by: Nikolay Borisov <kernel@xxxxxxxx> > --- > > Hello David, > > How about something like that? Looks good, but please split the patch so one adds the ratelimiting to the 'csum not found' message and another that introduces the global rate limiting and add a comment to the printk_limits table, with the relevant text from the changelog. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
