Re: [PATCH] btrfs-progs: add the error message when open fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 10, 2016 at 08:32:12AM +0900, Tsutomu Itoh wrote:
> Hi, David,
> 
> On 2016/06/09 22:13, David Sterba wrote:
> > On Thu, Jun 09, 2016 at 10:23:15AM +0900, Tsutomu Itoh wrote:
> >> When open in btrfs_open_devices failed, only the following message is
> >> displayed. Therefore the user doesn't understand the reason why open
> >> failed.
> >>
> >>   # btrfs check /dev/sdb8
> >>   Couldn't open file system
> >>
> >> This patch adds the error message when open fails.
> >
> > I think the message should be printed by the caller, not by the helper.
> 
> However in this case, error device name is not understood in the caller.

Right, makes more sense to print from within btrfs_open_devices.
Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux