On Wed, Jul 06, 2016 at 06:16:06PM +0800, Wang Xiaoguang wrote: > hello, > > On 07/05/2016 01:10 AM, David Sterba wrote: > > On Wed, Jun 29, 2016 at 01:12:16PM +0800, Wang Xiaoguang wrote: > > > > Can you please describe in more detail what is this patch fixing? > In original dump_space_info(), free space info is calculated by > info->total_bytes - info->bytes_used - info->bytes_pinned - > info->bytes_reserved - info->bytes_readonly, > but I think free space info should also minus info->bytes_may_use :) Not really what I expected. The change is correct but the changelog should say something "the 'used space' formula is missing the bytes_may_used, that is used elsewhere eg. __reserve_metadata_bytes or space_info_add_old_bytes". That way I have something to verify during the review. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
