On Thu, Jul 07, 2016 at 10:19:37PM -0400, Jeff Mahoney wrote: > On 7/7/16 9:48 PM, Jeff Mahoney wrote: > > On 6/24/16 6:14 PM, jeffm@xxxxxxxx wrote: > >> From: Jeff Mahoney <jeffm@xxxxxxxx> > >> > >> One of the common complaints I've heard from new and experienced > >> developers alike about the btrfs code is the ubiquity of > >> struct btrfs_root. There is one for every tree on disk and it's not > >> always obvious which root is needed in a particular call path. It can > >> be frustrating to spend time figuring out which root is required only > >> to discover that it's not actually used for anything other than > >> getting the fs-global struct btrfs_fs_info. > >> > >> The patchset contains several sections. > >> > >> 1) The fsid trace event patchset I posted earlier; I can rebase without this > >> but I'd prefer not to. > >> > >> 2) Converting btrfs_test_opt and friends to use an fs_info. > >> > >> 3) Converting tests to use an fs_info pointer whenever a root is used. > >> > >> 4) Moving sectorsize and nodesize to fs_info and cleaning up the > >> macros used to access them. > > > > This change was a little overzealous in free-space-cache.c, which hit > > block_group->sectorsize as well as root->sectorsize by accident. While > > the change is fine for general btrfs usage, it breaks the sanity tests > > since dummy block groups now depend on a dummy fs_info as well. > > There's also another error in btrfs_alloc_dummy_fs_info that doesn't > initialize sectorsize. > > Clearly my test config got CONFIG_BTRFS_FS_RUN_SANITY_TESTS disabled at > some point. :( I've tried to fix that but the tests still failed so for sake of getting for-next out, I've verified that commits up to "btrfs: btrfs_abort_transaction, drop root parameter" do boot so please send updates only to the following patches. My fixup attempts are in the branch for-4.8-fixups-buggy. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
