[PATCH 3/5] btrfs-progs: btrfs-crc: print usage on receiving invalid arguments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Usage is only printed if -h option is set. However it's nice to
do it when wrong option is set or the number of argument is wrong.

Signed-off-by: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>
---
 btrfs-crc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/btrfs-crc.c b/btrfs-crc.c
index 86dfe05..55a4c61 100644
--- a/btrfs-crc.c
+++ b/btrfs-crc.c
@@ -22,7 +22,7 @@
 #include "crc32c.h"
 #include "utils.h"

-void print_usage(void)
+void print_usage(int status)
 {
 	printf("usage: btrfs-crc filename\n");
 	printf("    print out the btrfs crc for \"filename\"\n");
@@ -30,7 +30,7 @@ void print_usage(void)
 	printf("    brute force search for file names with the given crc\n");
 	printf("      -s seed    the random seed (default: random)\n");
 	printf("      -l length  the length of the file names (default: 10)\n");
-	exit(1);
+	exit(status);
 }

 int main(int argc, char **argv)
@@ -57,9 +57,9 @@ int main(int argc, char **argv)
 			seed = atol(optarg);
 			break;
 		case 'h':
-			print_usage();
+			print_usage(1);
 		case '?':
-			return 255;
+			print_usage(255);
 		}
 	}

@@ -68,7 +68,7 @@ int main(int argc, char **argv)

 	if (!loop) {
 		if (check_argc_min(argc - optind, 1))
-			return 255;
+			print_usage(255);

 		printf("%12u - %s\n", crc32c(~1, str, strlen(str)), str);
 		return 0;
--
2.5.5
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux