On Wed, Jun 01, 2016 at 04:29:43PM +0800, Qu Wenruo wrote: > New convert doesn't insert holes for superblock migration range. > > Unlike old design, which only relocate 4K(superblock size) to other > places. > In new design, to make sure convert can handle different page size and > align chunk bytenr, we relocate the whole 64K range. This looks like a potential backward compatibility problem. In the unlikely scenario, mixing old and new convert to do conversion and rollback. Did you try that? > And if there is only a 4K used block inside 64K superblock migration range, it > will make converted fs has discontinuous file extents. > > This patch will fix it by inserting needed holes to avoid such > discontinuous error. > > Reported-by: Tsutomu Itoh <t-itoh@xxxxxxxxxxxxxx> > Signed-off-by: Qu Wenruo <quwenruo@xxxxxxxxxxxxxx> > --- > David, I'm very sorry, all these recently exposed bugs are related to > superblock migration range, and will only be triggered by special build > ext* images(Needs special space range be allocated in ext*) > > I'll try my best to create the minimal trigger e2image dump, our current > image is too large for test cases. Well, given the amount of last minute fixes I'm now hesitant to do 4.6 release with this patchset. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
