On Fri, May 27, 2016 at 03:00:38PM +0800, Feifei Xu wrote:
> In __test_eb_bitmaps(), we write random data to a bitmap. Then copy
> the bitmap to another bitmap that resides inside an extent buffer.
> Later we verify the values of corresponding bits in the bitmap and the
> bitmap inside the extent buffer. However, extent_buffer_test_bit()
> reads in byte granularity while test_bit() reads in unsigned long
> granularity. Hence we end up comparing wrong bits on big-endian
> systems such as ppc64. This commit fixes the issue by reading the
> bitmap in byte granularity.
>
> Reviewed-by: Chandan Rajendra <chandan@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Feifei Xu <xufeifei@xxxxxxxxxxxxxxxxxx>
> ---
> fs/btrfs/tests/extent-io-tests.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/tests/extent-io-tests.c b/fs/btrfs/tests/extent-io-tests.c
> index b06b13a..d33f28f 100644
> --- a/fs/btrfs/tests/extent-io-tests.c
> +++ b/fs/btrfs/tests/extent-io-tests.c
> @@ -275,6 +275,16 @@ out:
> return ret;
> }
>
> +/**
> + * test_bit_in_byte - Determine whether a bit is set in a byte
> + * @nr: bit number to test
> + * @addr: Address to start counting from
> + */
> +static inline int test_bit_in_byte(int nr, const u8 *addr)
> +{
> + return 1UL & (addr[nr/BITS_PER_BYTE] >> (nr & (BITS_PER_BYTE-1)));
minor nit:
return 1UL & (addr[nr / BITS_PER_BYTE] >> (nr & (BITS_PER_BYTE - 1)));
otherwise looks ok.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
