Re: [PATCH 2/3] Btrfs-progs: add three more valid checks for superblock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 11, 2016 at 03:36:29PM +0200, David Sterba wrote:
> On Mon, May 02, 2016 at 11:18:54AM -0700, Liu Bo wrote:
> > This adds valid checks for super_total_bytes, super_bytes_used and
> > super_stripesize.
> > 
> > Since these checks are made after superblock finishes checksum
> >  checking, this also adds a notice of "superblock checksum match but..".
> > 
> > This also replaces different kinds of printf with helper error() and
> > warning().
> 
> "This patch also does something completely different" is a good sign for
> patch splitting. I'll do that now but please keep that in mind next
> time.

Ah thanks a lot for that, I'd think more about maintenance.

Thanks,

-liubo
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux