Re: [PATCH RFC v2 00/16] Introduce low memory usage btrfsck mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 29, 2016 at 03:18:54PM +0800, Qu Wenruo wrote:
> The branch can be fetched from my github:
> https://github.com/adam900710/btrfs-progs.git low_mem_fsck_rebasing
...
> Changelog:
>   v1.1:
>     Fix a typo which makes keyed data backref check always fail
>   v2:
>     Don't return minus value with error bits. (Suggested by Josef)
>     Follow kernel code styling. (Suggested by Josef)
>     Enhance check on data backref count. (Slow down check speed though)

Is the branch low_mem_fsck_rebasing supposed to track the latest
version? I still see the negative values for error flags there.

I guess last thing you'd like to see commented in this patchset is
message formatting but it's consistently not matching the preferred
style everywhere, so please don't start the message with capitals, eg.:

	error("Block group[%llu %llu] relat..."

Testing the branch on the images in repository reported no problems
which is enough to add the branch to integration, but otherwise I'll
wait for Josef's review.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux