On Tue, May 10, 2016 at 04:01:05PM +0800, Anand Jain wrote: > > In more detail: > > > > * introduce _btrfs_printk that takes a string pointer as 1st argument > > (this could be used for messages before fs_info exists) > > * _btrfs_printk(NULL, ...) will be valid > > * then btrfs_printk(fs_info, ...) will become a wrapper > > _btrfs_printk(btrfs_sb(fs_info)->s_id, ...) > > * _btrfs_err & others do not need to be introduced, we can use the > > standard KERN_ERR > > Does it mean logs when fs_info is not available won't have fsid ? Right, we don't have fsid until we read the superblock from disk (somewhere in open_ctree). > Except for the logs in the context such as modload.. which does not > involve a disk. Consistency in logging would help. Like fishing-out > all logs related to a FSID. Yeah, this is probably related to your patches switching the messages to print fsid instead of device. Consistency is desirable of course, though we might need to make the output style configurable. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
