On Tue, May 03, 2016 at 08:59:58AM +0800, Qu Wenruo wrote: > > > David Sterba wrote on 2016/05/02 14:33 +0200: > > On Mon, Apr 25, 2016 at 04:55:32PM +0200, David Sterba wrote: > >> On Mon, Apr 18, 2016 at 09:20:18AM +0800, Qu Wenruo wrote: > >>> > >>> > >>> David Sterba wrote on 2016/04/15 13:17 +0200: > >>>> On Thu, Apr 14, 2016 at 02:24:34PM +0800, Qu Wenruo wrote: > >>>>> New btrfs-convert is using a lot of new macro in e2fsprogs 1.42. > >>>>> Unfortunately the new compatible layer for older e2fsprogs is still > >>>>> under development. > >>>> > >>>> It hasn't been released yet so it's not really a big problem, although > >>>> it makes testing on my side a bit harder. The configure-time check > >>>> should be 1.41 and until it's fixed we can print a warning. > >>>> > >>>> > >>> Did I missed something? > >>> > >>> I checkout 1.41.14 and it shows no cluster support in ext2fs.h. > >>> > >>> Also git describe shows it's v1.41.14-36-g1da5ef7, after the last v1.41 > >>> version. > >>> > >>> So I think the check should be 1.42, just as the patch. > >> > >> The idea is to keep lowest supported version 1.41, because this version > >> can be commonly found on enterprise distros. The lack of cluster is > >> expected and needs to be dealt with both build- and run-time. > > > > I've committed the following patch, as it was your idea to add the > > version check: > > I'm fine to 1.41 for now, but I'm afraid that the compatible layer won't > be any time soon. > So it may still broke 1.41 e2fsprogs. This means the convert rework has to be postponed until the compatibility with 1.41 is implemented, otherwise it would be regression. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
