On Fri, Apr 01, 2016 at 04:14:22PM -0400, Jeff Mahoney wrote: > The only part of this set that isn't just a direct cut-and-paste is > the last one which converts u8 and u64 values to __u8 and __u64 since > the former aren't exported via include/uapi. > > The goal is that everything required to use the btrfs ioctls for a > particular kernel release should be made available by exporting the uapi > headers for that release. > > I intend to use these for the strace ioctl decoding patch I've been > working on so that I don't need to duplicate of the definitions in the > code I send upstream as the final version of the patch. Prior to this > patchset, I had to duplicate nearly 100 defines and several structures -- > and that's without doing any item decoding at all. > > I do expect there might be some discussion here. :) I think this is a good refactoring, although my first reaction was not like that. Having the defines in the same directory is convenient, as searching is just *.[ch], but that's something I can live without. The other choice was to duplicate the defines yet another time, and this would be 3rd place, when counting btrfs-progs. As Josef and Bo seem to be fine with that as well, I'll put it to a branch and schedule for 4.7. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
