Re: [PATCH v2] btrfs-progs: subvolume functions reorg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 03/17/2016 10:19 PM, David Sterba wrote:
On Wed, Mar 16, 2016 at 10:14:33PM +0800, Anand Jain wrote:
Makes few subvol related functions usable outside of subvol
command set.

This is a preparatory patch for encryption support. The changes
here are:

Created new file subvolume.c
Created btrfs_get_subvol_info() from parts of cmd_subvol_show()
Moved get_subvol_name() to subvolume.c
Moved test_issubvolume() to subvolume.c
Created subvolume.h to define the above functions.

Such helpers are in utils.[ch], eg. there's test_issubvolname.

 You meant to move them/it to subvolume.c/h right ?

get_subvol_name could be renamed,

 will do.

factoring btrfs_get_subvol_info looks good.

So far the internal interfaces are not tidy,
so everything goes to utils.

 yes. very true.

It should be easier for you if you need to do some code
rearrangements.

 Sure. Thanks for suggesting. Will see what I can find.

- Anand

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux