Re: [PATCH] btrfs: rename save_error_info to set_fs_error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 03/16/2016 11:49 PM, David Sterba wrote:
On Wed, Mar 16, 2016 at 09:42:11PM +0800, Anand Jain wrote:
On 03/16/2016 06:05 PM, David Sterba wrote:
On Wed, Mar 16, 2016 at 04:43:05PM +0800, Anand Jain wrote:
@@ -171,7 +171,7 @@ void __btrfs_std_error(struct btrfs_fs_info *fs_info, const char *function,
   #endif

   	/* Don't go through full error handling during mount */
-	save_error_info(fs_info);
+	set_fs_error(fs_info);

The helper is too trivial, can you please drop it and replace by the
it's code here
In fact I was thinking that too, but comments below stop me doing that,
potentially this function might provision persistent FS state.

Yeah I saw it too of course, but the whole feature "save error state on
disk"  would need more work, the helper does not seem too useful. The
comment can be moved as well to keep it as a reminder.

 Great. Thanks for confirming. V2 is out.

- Anand


----
          /*
           * today we only save the error info into ram.  Long term we'll
           * also send it down to the disk
           */
-----
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux