On Thu, Mar 10, 2016 at 12:22:58PM +0800, Anand Jain wrote:
> Optional Label may or may not be set, or it might be set at some time
> later. However while debugging to search through the kernel logs the
> scripts would need the logs to be consistent, so logs search key words
> shouldn't depend on the optional variables, instead fsid is better.
I think the label is a useful information, as it's set by the user. So
if I'm looking to the log, I'll recognize the labels, not the device or
fsid.
It would be better to show all of them, ie. label, fsid, device and
transid. The line will get longer, but I hope it's ok.
Proposed order of the fields:
- device PATH
- devid ID
- fsid UUID
- transid TID
> - if (disk_super->label[0]) {
> - printk(KERN_INFO "BTRFS: device label %s ", disk_super->label);
> - } else {
> - printk(KERN_INFO "BTRFS: device fsid %pU ", disk_super->fsid);
> - }
> -
> - printk(KERN_CONT "devid %llu transid %llu %s\n", devid, transid, path);
> + printk(KERN_INFO "BTRFS: device fsid %pU devid %llu transid %llu %s\n",
> + disk_super->fsid, devid, transid, path);
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
