On 2016/03/09 4:24, Goffredo Baroncelli wrote:
> On 2016-03-07 04:05, Satoru Takeuchi wrote:
>> - It's better to show a warning message for the exceptional case
>> that one of objectid (in most case, inode number) reaches its
>> highest value. Show this message only once to avoid filling
>> dmesg with it.
>> - EOVERFLOW is more proper return value for this case.
>> ENOSPC is for "No space left on device" case and objectid isn't
>> related to any device.
>>
>> Signed-off-by: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>
>> ---
>> This patch can be applied to 4.5-rc7
>> ---
>> fs/btrfs/inode-map.c | 10 +++++++++-
>> 1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/fs/btrfs/inode-map.c b/fs/btrfs/inode-map.c
>> index e50316c..f5e3228 100644
>> --- a/fs/btrfs/inode-map.c
>> +++ b/fs/btrfs/inode-map.c
>> @@ -556,7 +556,15 @@ int btrfs_find_free_objectid(struct btrfs_root *root, u64 *objectid)
>> mutex_lock(&root->objectid_mutex);
>>
>> if (unlikely(root->highest_objectid >= BTRFS_LAST_FREE_OBJECTID)) {
>> - ret = -ENOSPC;
>> + static bool __warned = false;
>
>
> Please, don't use a static GLOBAL variable. I suggest to move to a "per filesystem" variables for two main reasons:
>
> 1) if in the (very unlikely) case where two different filesystems reach BTRFS_LAST_FREE_OBJECTID, the first error will hide the second one.
>
> 2) if you umount and remount the filesystem the error is not shown anymore. A module unload/load or a reboot is required.
> If something strange happens, one of the first thing that the user does, is to umount/remount the filesystem. But the error is not show anymore. This could complicate the diagnosis of the problem.
OK, I see.
I rethink what should this patch be since it's
overkill to prepare per-filesystem variable just
for this warning message.
I'll resend patch which shows this message
every time when hitting this condition instead of
does it just once.
Thanks,
Satoru
>
>
>
>
>> +
>> + if (unlikely(!__warned)) {
>> + btrfs_warn(root->fs_info,
>> + "The objectid of root %llu reaches its highest value.\n",
>> + root->root_key.objectid);
>> + __warned = true;
>> + }
>> + ret = -EOVERFLOW;
>> goto out;
>> }
>>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
