- It's better to show a warning message for the exceptional case
that one of objectid (in most case, inode number) reaches its
highest value. Show this message only once to avoid filling
dmesg with it.
- EOVERFLOW is more proper return value for this case.
ENOSPC is for "No space left on device" case and objectid isn't
related to any device.
Signed-off-by: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>
---
This patch can be applied to 4.5-rc7
---
fs/btrfs/inode-map.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/inode-map.c b/fs/btrfs/inode-map.c
index e50316c..f5e3228 100644
--- a/fs/btrfs/inode-map.c
+++ b/fs/btrfs/inode-map.c
@@ -556,7 +556,15 @@ int btrfs_find_free_objectid(struct btrfs_root *root, u64 *objectid)
mutex_lock(&root->objectid_mutex);
if (unlikely(root->highest_objectid >= BTRFS_LAST_FREE_OBJECTID)) {
- ret = -ENOSPC;
+ static bool __warned = false;
+
+ if (unlikely(!__warned)) {
+ btrfs_warn(root->fs_info,
+ "The objectid of root %llu reaches its highest value.\n",
+ root->root_key.objectid);
+ __warned = true;
+ }
+ ret = -EOVERFLOW;
goto out;
}
--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
