On Wed, Feb 24, 2016 at 12:29 AM, Satoru Takeuchi
<takeuchi_satoru@xxxxxxxxxxxxxx> wrote:
> On 2016/02/23 2:52, fdmanana@xxxxxxxxxx wrote:
>>
>> From: Filipe Manana <fdmanana@xxxxxxxx>
>>
>> In the listxattrs handler, we were not listing all the xattrs that are
>> packed in the same btree item, which happens when multiple xattrs have
>> a name that when crc32c hashed produce the same checksum value.
(snip)
This gives me (with gcc 5.3.0):
fs/btrfs/xattr.c: In function 'btrfs_listxattr':
fs/btrfs/xattr.c:357:8: warning: 'this_len' may be used uninitialized
in this function [-Wmaybe-uninitialized]
cur += this_len;
^
fs/btrfs/xattr.c:357:8: warning: 'cur' may be used uninitialized in
this function [-Wmaybe-uninitialized]
fs/btrfs/xattr.c:327:9: warning: 'item_size' may be used uninitialized
in this function [-Wmaybe-uninitialized]
while (cur < item_size) {
^
fs/btrfs/xattr.c:358:7: warning: 'di' may be used uninitialized in
this function [-Wmaybe-uninitialized]
di = (struct btrfs_dir_item *)((char *)di + this_len);
^
And at least from a compiler POV these seem to have merit, caused by a possibly
premature "goto next" above the "while (cur < item_size)" loop.
cheers
Holger
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
