Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2016-02-20 at 12:17 -0600, Simon Quigley wrote:
> checkpatch.pl reported a warning of over 80 characters on line 1833
[]
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
[]
> @@ -1830,7 +1830,11 @@ static int iterate_inode_extrefs(u64 inum, struct btrfs_root *fs_root,
>  	unsigned long ptr;
>  
>  	while (1) {
> -		ret = btrfs_find_one_extref(fs_root, inum, offset, path, &extref,
> +		ret = btrfs_find_one_extref(fs_root,
> +						inum,
> +						offset,
> +						path,
> +						&extref,
>  					    &offset);

I think this is poor because all the arguments aren't aligned.

It'd be nicer like:

		ret = btrfs_find_one_extref(fs_root, inum, offset, path,
					    &extref, &offset);

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux