Re: [PATCH] btrfs: sysfs: check initialization state before updating features

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 27, 2016 at 11:14 AM, David Sterba <dsterba@xxxxxxxx> wrote:
> If the mount phase is not finished, we can't update the sysfs files.
>
> Reported-by: Chris Mason <clm@xxxxxx>
> Signed-off-by: David Sterba <dsterba@xxxxxxxx>
> ---
>  fs/btrfs/sysfs.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
> index 6986886243bf..1ae146a8093c 100644
> --- a/fs/btrfs/sysfs.c
> +++ b/fs/btrfs/sysfs.c
> @@ -804,6 +804,9 @@ void btrfs_sysfs_feature_update(struct btrfs_fs_info *fs_info,
>         fs_devs = fs_info->fs_devices;
>         fsid_kobj = &fs_devs->fsid_kobj;
>
> +       if (!fsid_kobj.state_initialized)
> +               return;
> +

uhm..

fs/btrfs/sysfs.c: In function 'btrfs_sysfs_feature_update':
fs/btrfs/sysfs.c:807:16: error: request for member 'state_initialized'
in something not a structure or union
  if (!fsid_kobj.state_initialized)
                ^

I think this should be fsid_kobj->state_initialized, no?

-h
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux