Re: [PATCH] btrfs: cleanup unusable parameters from ctree.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 25, 2015 at 06:21:09PM -0500, Caio Lima wrote:
> Cleanup of ununsed parameters in btrfs_header_chunk_tree_uuid,
> btrfs_leaf_data and btrfs_defrag_cancelled

The parameters are unused so the question is what are the functions
supposed to do. They just return offset within the header or leaf
structures.

Adding the _offset to the current function names would make them too
long, I suggest to opencode the 'offsetof(struct ..., member)' instead.
We do that anyway in many places.

Please keep btrfs_defrag_cancelled as-is for now.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux