Re: [PATCH] btrfs: initialize the seq counter in struct btrfs_device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 15, 2016 at 02:37:15PM +0100, Sebastian Andrzej Siewior wrote:
> I managed to trigger this:
> | INFO: trying to register non-static key.
> | the code is fine but needs lockdep annotation.
> | turning off the locking correctness validator.
> | CPU: 1 PID: 781 Comm: systemd-gpt-aut Not tainted 4.4.0-rt2+ #14
> | Hardware name: ARM-Versatile Express
> | [<80307cec>] (dump_stack)
> | [<80070e98>] (__lock_acquire)
> | [<8007184c>] (lock_acquire)
> | [<80287800>] (btrfs_ioctl)
> | [<8012a8d4>] (do_vfs_ioctl)
> | [<8012ac14>] (SyS_ioctl)
> 
> so I think that btrfs_device_data_ordered_init() is not invoked behind
> a macro somewhere.

Right, and it hasn't been invoked anywhere  since it's introduction.
Accidentally working because the initial value is 0 (and the device
struct is zeroed), but the lockdep structure is not valid.

> Fixes: 7cc8e58d53cd ("Btrfs: fix unprotected device's variants on 32bits machine")
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

Reviewed-by: David Sterba <dsterba@xxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux